-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix list fields detection in TestCRDFieldPresenceInUnstructured #3651
test: fix list fields detection in TestCRDFieldPresenceInUnstructured #3651
Conversation
/assign @acpana |
Fixes #3571 |
/cc @jasonvigil |
374fbc9
to
694dee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you loads for taking this on 💯
I spotted checked some of the newly fixed exceptions and can confirm that all fixes in #3636 are present here too!
good job! 🥇
if itemMap, ok := item.(map[string]interface{}); ok { | ||
if hasField(itemMap, remainingPath) { | ||
return true // found the field in one of the items, we can stop searching | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may be "double checking" field paths here in the case where a remaining path is not actually present anywhere else. We check it here in the small loop and then again in the outer loop.
But if that's the case we can live with that for now 💯 .
/lgtm |
/assign yuwenma |
/lgtm |
This PR isn't merging for some reason. I am guessing perhaps because @acpana used the github method of approving the PR, rather than the oss-prow commands. I will try to approve also, to see if that un-sticks it. |
Hmm, doesn't seem to have worked. Looks like it was fine before, we just need approval from @yuwenma |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana, cheftako, jasonvigil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5af3b35
into
GoogleCloudPlatform:master
Unblocks #3632
Fixed the incorrect detection of list fields in
TestCRDFieldPresenceInUnstructured
.e.g.