Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate SecureSourceManager instance fields into input and observed structs #3746

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Separate SecureSourceManager instance fields into input and observed structs #3746

wants to merge 11 commits into from

Conversation

ericpang777
Copy link
Contributor

@ericpang777 ericpang777 commented Feb 20, 2025 •
edited
Loading

Change description

Add createTimestamp, updateTimestamp, and labels fields as well

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericpang777 ericpang777 marked this pull request as ready for review February 20, 2025 23:00
@ericpang777
Copy link
Contributor Author

@gemmahou

@ericpang777 ericpang777 mentioned this pull request Feb 20, 2025
Open
2 tasks
@ericpang777 ericpang777 changed the title Separate SecureSourceManager fields into input and observed structs Separate SecureSourceManager instance fields into input and observed structs Feb 20, 2025
@ericpang777 ericpang777 mentioned this pull request Feb 21, 2025
Open
2 tasks
@ericpang777
Copy link
Contributor Author

Test failure looks unrelated

jingyih
jingyih reviewed Feb 21, 2025
View reviewed changes
apis/securesourcemanager/v1alpha1/types.generated.go
@@ -14,10 +14,6 @@

package v1alpha1

// +kcc:proto=google.cloud.securesourcemanager.v1.Instance.HostConfig
type Instance_HostConfig struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @yuwenma this looks like another example that we need this bug fix.
#3667

@gemmahou
Copy link
Collaborator

Looks good. Pending updates on roundtrip_test.go and _http.log

@gemmahou
Copy link
Collaborator

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih jingyih left review comments

@gemmahou gemmahou gemmahou left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@gemmahou gemmahou

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericpang777 @gemmahou @jingyih