Promote BatchJob to Beta #5412
Promote BatchJob to Beta #5412
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
issue #5338 |
| // * `batch-hpc-rocky`: use Batch HPC Rocky Linux images. | ||
| // +kcc:proto:field=google.cloud.batch.v1.AllocationPolicy.Disk.image | ||
| ImageRef *v1alpha1.ResourceRef `json:"imageRef,omitempty"` | ||
| Image *string `json:"image,omitempty"` |
There was a problem hiding this comment.
This looks like an imageRef?
| // BatchJobSpec defines the desired state of BatchJob | ||
| // +kcc:spec:proto=google.cloud.batch.v1.Job | ||
| type BatchJobSpec struct { | ||
| ParentRef *parent.ProjectAndLocationRef `json:",inline"` |
There was a problem hiding this comment.
Nit: (not for this PR) ... I've realized that you probably mean ProjectRefAndLocation (?)
|
|
||
| var BatchTaskGVK = GroupVersion.WithKind("BatchTask") | ||
|
|
||
| type Parent struct { |
There was a problem hiding this comment.
Nit: Isn't this *parent.ProjectAndLocationRef
There was a problem hiding this comment.
It is. But this PR should only contain code for BatchJob promotion.
| [refs] crd=batchjobs.batch.cnrm.cloud.google.com version=v1alpha1: field ".spec.allocationPolicy.serviceAccount" should be a reference | ||
| [refs] crd=batchjobs.batch.cnrm.cloud.google.com version=v1beta1: field ".spec.allocationPolicy.instances[].policy.bootDisk.image" should be a reference | ||
| [refs] crd=batchjobs.batch.cnrm.cloud.google.com version=v1beta1: field ".spec.allocationPolicy.instances[].policy.disks[].newDisk.image" should be a reference | ||
| [refs] crd=batchjobs.batch.cnrm.cloud.google.com version=v1beta1: field ".spec.allocationPolicy.serviceAccount" should be a reference |
There was a problem hiding this comment.
Yeah, I think this is correct ... both image and serviceAccount should be references?
2 participants
BRIEF Change description
Fixes #
WHY do we need this change?
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Please indicate the intended milestone.
Tests you have done
make ready-prto ensure this PR is ready for review.