feat: Add api, fuzzer and mapper for TagsTagBinding #5416
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
issue #5299 |
|
/assign @justinsb |
| return obj.Spec.ParentRef.External, nil | ||
| } | ||
| if obj.Spec.ParentRef.Name != "" { | ||
| // TODO: This is not quite right, we need to resolve the project number. |
There was a problem hiding this comment.
I have been calling common.NormalizeRefs first (and then we can treat External == "" as an error)
There was a problem hiding this comment.
Ah - a meta point - this is why it's problematic to introduce identity & reference here. AFAICT this code is currently unused and therefore untested?
There was a problem hiding this comment.
Right, it is unused and untested. It would be changed in the next PR (controller)
| // If the "External" is given in the other resource's spec.TagsTagValueRef, the given value will be used. | ||
| // Otherwise, the "Name" and "Namespace" will be used to query the actual TagsTagValue object from the cluster. | ||
| func (r *TagsTagValueRef) NormalizedExternal(ctx context.Context, reader client.Reader, otherNamespace string) (string, error) { | ||
| if r.External != "" && r.Name != "" { |
There was a problem hiding this comment.
Can we use the common function?
I want to merge this PR and have the code template fixed in a separate PR, and have this identity/reference fixed in the next controller PR. Theoretically the identity and reference in this PR shows that they come from the right place: generate.sh if the file does not exist., which uses the code template. |
2 participants
BRIEF Change description
Fixes #
WHY do we need this change?
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Please indicate the intended milestone.
Tests you have done
make ready-prto ensure this PR is ready for review.