Skip to content

Conversation

yuwenma
Copy link
Collaborator

@yuwenma yuwenma commented Oct 13, 2025

BRIEF Change description

Fixes #

WHY do we need this change?

Special notes for your reviewer:

Does this PR add something which needs to be 'release noted'?


  • Reviewer reviewed release note.

Additional documentation e.g., references, usage docs, etc.:


Intended Milestone

Please indicate the intended milestone.

  • Reviewer tagged PR with the actual milestone.

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@yuwenma yuwenma force-pushed the BackupDRBackupVault branch from cc2d66c to ebd60f9 Compare October 13, 2025 21:17
@yuwenma
Copy link
Collaborator Author

yuwenma commented Oct 14, 2025

/assign @justinsb


var BackupDRBackupVaultGVK = GroupVersion.WithKind("BackupDRBackupVault")

type Parent struct {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement is to use the parent.ProjectAndLocation. I have a gemini guide to do it (and other resources). I plan to track that as a separate effort.

@yuwenma yuwenma force-pushed the BackupDRBackupVault branch from ebd60f9 to 6c2a8f4 Compare October 14, 2025 19:19
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[missing_field] crd=assetsavedqueries.asset.cnrm.cloud.google.com version=v1beta1: field ".spec.labels" is not set in unstructured objects
[missing_field] crd=assetsavedqueries.asset.cnrm.cloud.google.com version=v1beta1: field ".spec.organizationRef" is not set; neither 'external' nor 'name' are set
[missing_field] crd=backupdrbackupvaults.backupdr.cnrm.cloud.google.com version=v1beta1: field ".spec.annotations" is not set in unstructured objects
[missing_field] crd=backupdrbackupvaults.backupdr.cnrm.cloud.google.com version=v1beta1: field ".spec.labels" is not set in unstructured objects
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for ##5395 to fix the labels.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you did not want to add spec.labels to your list of tasks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. That's what 5395 will help (remove spec.labels, fix fuzzer/mapper, handle labels in controller and add the fixture test to verify labels)

@yuwenma yuwenma force-pushed the BackupDRBackupVault branch from 6c2a8f4 to a0abfee Compare October 14, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants