Added google_apigee_api_deployment resource #12291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
roaks3
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Overall LGTM, but a couple of high-level questions:
- Does this actually need to be a handwritten resource, or could it be implemented as an mmv1 resource like
mmv1/products/apigee/Environment.yaml? I didn't notice anything that needed to be handwritten here, and it looked like the sharedflow resource neededsendRequestRawBodyWithTimeout, which I don't see used here. - Do you know why the test needs to be skipped in VCR?
| An API proxy deployment can be imported using any of these accepted formats: | ||
|
|
||
| * `organizations/{{org_id}}/environments/{{environment}}/apis/{{api_id}}/revisions/{{revision}}/deployments/{{name}}` | ||
| * `{{org_id}}/{{environment}}/{{sharedflow_id}}/{{revision}}/{{name}}` |
There was a problem hiding this comment.
s/sharedflow_id/api_id/ ?
Similar for various shared flow references below this on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to add the google_apigee_api_deployment resource