Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mirroring and Intercept resources to Network Security. #12292

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

duvni
Copy link

@duvni duvni commented Nov 11, 2024

Removal from google-private: https://cloud-internal-review.git.corp.google.com/c/cloud-graphite-eng/magic-modules-private-overrides/+/49230

`google_network_security_intercept_deployment`, `google_network_security_intercept_deployment_group`, `google_network_security_intercept_endpoint_group_association`, `google_network_security_intercept_endpoint_group`, `google_network_security_mirroring_deployment`, `google_network_security_mirroring_deployment_group`, `google_network_security_mirroring_endpoint_group_association`, `google_network_security_mirroring_endpoint_group`

Removal from google-private: https://cloud-internal-review.git.corp.google.com/c/cloud-graphite-eng/magic-modules-private-overrides/+/49230

```release-note:new-resource
`google_network_security_intercept_deployment`, `google_network_security_intercept_deployment_group`, `google_network_security_intercept_endpoint_group_association`, `google_network_security_intercept_endpoint_group`, `google_network_security_mirroring_deployment`, `google_network_security_mirroring_deployment_group`, `google_network_security_mirroring_endpoint_group_association`, `google_network_security_mirroring_endpoint_group`
```
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1485 insertions(+))
google-beta provider: Diff ( 41 files changed, 8256 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 8 files changed, 728 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_intercept_deployment (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_intercept_deployment" "primary" {
  labels = # value needed
}

Resource: google_network_security_intercept_deployment_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_intercept_deployment_group" "primary" {
  labels = # value needed
}

Resource: google_network_security_intercept_endpoint_group (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_intercept_endpoint_group" "primary" {
  labels = # value needed
}

Resource: google_network_security_intercept_endpoint_group_association (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_intercept_endpoint_group_association" "primary" {
  labels = # value needed
}

Resource: google_network_security_mirroring_deployment (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_mirroring_deployment" "primary" {
  labels = # value needed
}

Resource: google_network_security_mirroring_deployment_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_mirroring_deployment_group" "primary" {
  labels = # value needed
}

Resource: google_network_security_mirroring_endpoint_group (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_mirroring_endpoint_group" "primary" {
  labels = # value needed
}

Resource: google_network_security_mirroring_endpoint_group_association (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_mirroring_endpoint_group_association" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 35
Skipped tests: 4
Affected tests: 8

Click here to see the affected service packages
  • networksecurity

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkSecurityInterceptDeploymentGroup_networkSecurityInterceptDeploymentGroupBasicExample
  • TestAccNetworkSecurityInterceptDeployment_networkSecurityInterceptDeploymentBasicExample
  • TestAccNetworkSecurityInterceptEndpointGroupAssociation_networkSecurityInterceptEndpointGroupAssociationBasicExample
  • TestAccNetworkSecurityInterceptEndpointGroup_networkSecurityInterceptEndpointGroupBasicExample
  • TestAccNetworkSecurityMirroringDeploymentGroup_networkSecurityMirroringDeploymentGroupBasicExample
  • TestAccNetworkSecurityMirroringDeployment_networkSecurityMirroringDeploymentBasicExample
  • TestAccNetworkSecurityMirroringEndpointGroupAssociation_networkSecurityMirroringEndpointGroupAssociationBasicExample
  • TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecurityInterceptDeploymentGroup_networkSecurityInterceptDeploymentGroupBasicExample [Error message] [Debug log]
TestAccNetworkSecurityInterceptDeployment_networkSecurityInterceptDeploymentBasicExample [Error message] [Debug log]
TestAccNetworkSecurityInterceptEndpointGroupAssociation_networkSecurityInterceptEndpointGroupAssociationBasicExample [Error message] [Debug log]
TestAccNetworkSecurityInterceptEndpointGroup_networkSecurityInterceptEndpointGroupBasicExample [Error message] [Debug log]
TestAccNetworkSecurityMirroringDeploymentGroup_networkSecurityMirroringDeploymentGroupBasicExample [Error message] [Debug log]
TestAccNetworkSecurityMirroringDeployment_networkSecurityMirroringDeploymentBasicExample [Error message] [Debug log]
TestAccNetworkSecurityMirroringEndpointGroupAssociation_networkSecurityMirroringEndpointGroupAssociationBasicExample [Error message] [Debug log]
TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1511 insertions(+))
google-beta provider: Diff ( 41 files changed, 8308 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 8 files changed, 728 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_intercept_deployment (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_intercept_deployment" "primary" {
  labels = # value needed
}

Resource: google_network_security_intercept_deployment_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_intercept_deployment_group" "primary" {
  labels = # value needed
}

Resource: google_network_security_intercept_endpoint_group (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_intercept_endpoint_group" "primary" {
  labels = # value needed
}

Resource: google_network_security_intercept_endpoint_group_association (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_intercept_endpoint_group_association" "primary" {
  labels = # value needed
}

Resource: google_network_security_mirroring_deployment (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_mirroring_deployment" "primary" {
  labels = # value needed
}

Resource: google_network_security_mirroring_deployment_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_mirroring_deployment_group" "primary" {
  labels = # value needed
}

Resource: google_network_security_mirroring_endpoint_group (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_mirroring_endpoint_group" "primary" {
  labels = # value needed
}

Resource: google_network_security_mirroring_endpoint_group_association (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_mirroring_endpoint_group_association" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 35
Skipped tests: 4
Affected tests: 8

Click here to see the affected service packages
  • networksecurity

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkSecurityInterceptDeploymentGroup_networkSecurityInterceptDeploymentGroupBasicExample
  • TestAccNetworkSecurityInterceptDeployment_networkSecurityInterceptDeploymentBasicExample
  • TestAccNetworkSecurityInterceptEndpointGroupAssociation_networkSecurityInterceptEndpointGroupAssociationBasicExample
  • TestAccNetworkSecurityInterceptEndpointGroup_networkSecurityInterceptEndpointGroupBasicExample
  • TestAccNetworkSecurityMirroringDeploymentGroup_networkSecurityMirroringDeploymentGroupBasicExample
  • TestAccNetworkSecurityMirroringDeployment_networkSecurityMirroringDeploymentBasicExample
  • TestAccNetworkSecurityMirroringEndpointGroupAssociation_networkSecurityMirroringEndpointGroupAssociationBasicExample
  • TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecurityMirroringDeploymentGroup_networkSecurityMirroringDeploymentGroupBasicExample [Debug log]
TestAccNetworkSecurityMirroringDeployment_networkSecurityMirroringDeploymentBasicExample [Debug log]
TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccNetworkSecurityInterceptDeploymentGroup_networkSecurityInterceptDeploymentGroupBasicExample [Error message] [Debug log]
TestAccNetworkSecurityInterceptDeployment_networkSecurityInterceptDeploymentBasicExample [Error message] [Debug log]
TestAccNetworkSecurityInterceptEndpointGroupAssociation_networkSecurityInterceptEndpointGroupAssociationBasicExample [Error message] [Debug log]
TestAccNetworkSecurityInterceptEndpointGroup_networkSecurityInterceptEndpointGroupBasicExample [Error message] [Debug log]
TestAccNetworkSecurityMirroringEndpointGroupAssociation_networkSecurityMirroringEndpointGroupAssociationBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@roaks3
Copy link
Contributor

roaks3 commented Nov 13, 2024

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1535 insertions(+))
google-beta provider: Diff ( 41 files changed, 8356 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 8 files changed, 728 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 35
Skipped tests: 4
Affected tests: 8

Click here to see the affected service packages
  • networksecurity

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkSecurityInterceptDeploymentGroup_networkSecurityInterceptDeploymentGroupBasicExample
  • TestAccNetworkSecurityInterceptDeployment_networkSecurityInterceptDeploymentBasicExample
  • TestAccNetworkSecurityInterceptEndpointGroupAssociation_networkSecurityInterceptEndpointGroupAssociationBasicExample
  • TestAccNetworkSecurityInterceptEndpointGroup_networkSecurityInterceptEndpointGroupBasicExample
  • TestAccNetworkSecurityMirroringDeploymentGroup_networkSecurityMirroringDeploymentGroupBasicExample
  • TestAccNetworkSecurityMirroringDeployment_networkSecurityMirroringDeploymentBasicExample
  • TestAccNetworkSecurityMirroringEndpointGroupAssociation_networkSecurityMirroringEndpointGroupAssociationBasicExample
  • TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecurityInterceptDeploymentGroup_networkSecurityInterceptDeploymentGroupBasicExample [Debug log]
TestAccNetworkSecurityInterceptDeployment_networkSecurityInterceptDeploymentBasicExample [Debug log]
TestAccNetworkSecurityInterceptEndpointGroupAssociation_networkSecurityInterceptEndpointGroupAssociationBasicExample [Debug log]
TestAccNetworkSecurityInterceptEndpointGroup_networkSecurityInterceptEndpointGroupBasicExample [Debug log]
TestAccNetworkSecurityMirroringDeploymentGroup_networkSecurityMirroringDeploymentGroupBasicExample [Debug log]
TestAccNetworkSecurityMirroringDeployment_networkSecurityMirroringDeploymentBasicExample [Debug log]
TestAccNetworkSecurityMirroringEndpointGroupAssociation_networkSecurityMirroringEndpointGroupAssociationBasicExample [Debug log]
TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants