add deletion_protection for autonomousDatabase resource

[tulika-aakriti]

part of : hashicorp/terraform-provider-google#20284
Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

oracledatabase: added `deletion_protection` field to `google_oracle_database_autonomous_database`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 29 insertions(+), 145 deletions(-))
google-beta provider: Diff ( 4 files changed, 29 insertions(+), 145 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• oracledatabase

🟢 All tests passed!

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[slevenick]

I don't believe we can add this in a minor version of the provider because it would be changing the default behavior of the resource. @rileykarson is that correct in this case?

[rileykarson]

Yeah, we'd strongly prefer to not do so outside of a major. We discuss in https://googlecloudplatform.github.io/magic-modules/best-practices/immutable-fields/ that immutable fields are expected in Terraform. However, if there's undue risk w/ deleting these resources past the standard risks of a database deletion we're glad to continue to discuss an exception here.

[tulika-aakriti]

I see that the major release is once every year which might be risk for customer.
The deletion api will delete all the exisiting data from database and the data in the third party i.e oracleDatabase and there will be no way for a user to restore the data. I see many GCP products like bugQuery and SQL uses this to warn the user regarding the data loss. Moving forward we are planning to add update API and will continue to use deletion_protection as a mitigations for accidental delete.

[tulika-aakriti]

We don't support update API as of now, so every update call can lead to accidental deletion. Can we get exception for 3 of our resources for weekly release. Our service onboarded few weeks ago and we don't have any active customers now.

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

I'm fine with this being added. We should sync up merging with the other 3 resources so they all go out at the same time