Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Cluster Cross Cluster Replication addition #12300

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

manjunathganga
Copy link

@manjunathganga manjunathganga commented Nov 11, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

redis: added the `cross_cluster_replication_config` field to the `google_redis_cluster` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1008 insertions(+))
google-beta provider: Diff ( 4 files changed, 1163 insertions(+), 47 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 252 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  cross_cluster_replication_config {
    secondary_clusters {
      cluster = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 17
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages
  • redis

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_createClusterWithNodeType
  • TestAccRedisCluster_createClusterWithZoneDistribution
  • TestAccRedisCluster_createUpdateDeletionProtection
  • TestAccRedisCluster_persistenceUpdate
  • TestAccRedisCluster_redisClusterSecondaryExample
  • TestAccRedisCluster_switchoverAndDetachSecondary
  • TestAccRedisCluster_updateRedisConfigs
  • TestAccRedisCluster_updateReplicaCount
  • TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_createClusterWithNodeType [Debug log]
TestAccRedisCluster_createClusterWithZoneDistribution [Debug log]
TestAccRedisCluster_createUpdateDeletionProtection [Debug log]
TestAccRedisCluster_persistenceUpdate [Debug log]
TestAccRedisCluster_updateRedisConfigs [Debug log]
TestAccRedisCluster_updateReplicaCount [Debug log]
TestAccRedisCluster_updateShardCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterSecondaryExample [Error message] [Debug log]
TestAccRedisCluster_switchoverAndDetachSecondary [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1008 insertions(+))
google-beta provider: Diff ( 4 files changed, 1163 insertions(+), 47 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 252 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  cross_cluster_replication_config {
    secondary_clusters {
      cluster = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • redis

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterSecondaryExample
  • TestAccRedisCluster_switchoverAndDetachSecondary

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_switchoverAndDetachSecondary [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterSecondaryExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1008 insertions(+))
google-beta provider: Diff ( 4 files changed, 1163 insertions(+), 47 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 252 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  cross_cluster_replication_config {
    secondary_clusters {
      cluster = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 25
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterSecondaryExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_redisClusterSecondaryExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants