Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase google cloud netapp create storagePool timeout to 30 mins #12313

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mehul3217
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

netapp: increase timeout of StoragePool Resource to 30 mins

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp

🟢 All tests passed!

View the build log

@okrause
Copy link
Contributor

okrause commented Nov 14, 2024

Hello @shuyama1 , please hold back from merging this. We like to set this timeout to 45min instead of 30min. @Mehul3217 will send an updated PR the next few days.

@shuyama1
Copy link
Member

Hello @shuyama1 , please hold back from merging this. We like to set this timeout to 45min instead of 30min. @Mehul3217 will send an updated PR the next few days.

Sure. Thanks for the heads up. I'll convert this PR to draft for now and please mark it as ready to review when it's ready. Thank you!

@shuyama1 shuyama1 marked this pull request as draft November 14, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants