Made traffic_split field use default_from_api

[melinath]

Testing behavior of "{}": gpaste/6027469969948672
Testing behavior of "{}" if there's already a value set remotely: gpaste/4841573379735552

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

vertexai: fixed issue with google_vertex_ai_endpoint where upgrading to 6.11.0 would delete all traffic splits that were set outside Terraform (which was previously a required step for all meaningful use of this resource).

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 2 files changed, 8 insertions(+), 9 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  traffic_split = # value needed
}

[modular-magician]

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• vertexai

🟢 All tests passed!

View the build log

[slevenick]

LGTM in general, but did you test specifically unsetting this field by sending the {} value?

In the paste you linked I see sending trafficSplit: {} but I don't see that trafficSplit was present with a value before that is sent. I'd be curious if the PATCH actually unsets the field or if it is just ignored because it has an empty value for it

[melinath]

yeah, I wasn't able to set the field yesterday - going to test those cases this morning :-)

[melinath]

/gcbrun to regenerate branches

[melinath]

yeah it works: gpaste/4841573379735552

PATCH unsets the field if provided "{}".

[melinath]

aaand I need to approve my own builds now too 🤦

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 2 files changed, 8 insertions(+), 9 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_endpoint (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint" "primary" {
  traffic_split = # value needed
}

[modular-magician]

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• vertexai

🟢 All tests passed!

View the build log