Terraform Integration for Capability #13282
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 4671 Click here to see the affected service packages
Action takenFound 294 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
modular-magician
added
awaiting-approval
| @@ -17,5 +17,11 @@ display_name: 'Resource Manager' | |||
| versions: | |||
| - name: 'ga' | |||
| base_url: 'https://cloudresourcemanager.googleapis.com/v1/' | |||
| - name: 'beta' | |||
| base_url: 'https://cloudresourcemanager.googleapis.com/v3/' | |||
There was a problem hiding this comment.
I don't think we can add the v3 API as a "beta" of this product. We'll want to add a new product specifically for resourcemanager v3, and then we can use legacy_name to rename the product to resource_manager to match other resources.
Switching users on the beta provider from v1 -> v3 could trigger issues on other resources
| # TODO | ||
| description: | | ||
| Capability | ||
| # TODO |
| resource "google_resource_manager_capability" "{{$.PrimaryResourceId}}" { | ||
| provider = google-beta | ||
| value = true | ||
| parent = "{{index $.Vars "parent"}}" |
There was a problem hiding this comment.
Please create this folder as part of the test rather than passing a hard-coded value
| resource "google_resource_manager_capability" "capability" { | ||
| provider = google-beta | ||
| value = true | ||
| parent = "folders/395566339940" |
There was a problem hiding this comment.
Same here, create this rather than passing a hard-coded value
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 4678 Click here to see the affected service packages
Action takenFound 29 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Add support for Capability in terraform.
Capability is a singleton resource part of Resource Manager product.