Fix the incorrect default GKE cpu_cfs_quota

[zicongmei]

Fixes hashicorp/terraform-provider-google#15767

Fix an incorrect default value in GKE cpu_cfs_quota

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: fixed incorrect default value in `cpu_cfs_quota`. Undefined  `cpu_cfs_quota` will be configured to `true`.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field node_config.kubelet_config.cpu_cfs_quota default value changed from to true on google_container_cluster - reference
• Field node_config.kubelet_config.cpu_cfs_quota default value changed from to true on google_container_node_pool - reference
• Field node_pool.node_config.kubelet_config.cpu_cfs_quota default value changed from to true on google_container_cluster - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (437 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      kubelet_config {
        cpu_cfs_quota = # value needed
      }
    }
  }
}

[hao-nan-li]

This looks to be a breaking change and can only be included in major releases. Our team planned a 7.0.0 release in August/September, which could include this in.

[modular-magician]

Tests analytics

Total tests: 226
Passed tests: 213
Skipped tests: 11
Affected tests: 2

Click here to see the affected service packages

• container

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
• TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool [Debug log]
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 44 insertions(+))
google-beta provider: Diff ( 2 files changed, 44 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field node_config.kubelet_config.cpu_cfs_quota default value changed from to true on google_container_cluster - reference
• Field node_config.kubelet_config.cpu_cfs_quota default value changed from to true on google_container_node_pool - reference
• Field node_pool.node_config.kubelet_config.cpu_cfs_quota default value changed from to true on google_container_cluster - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (438 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      kubelet_config {
        cpu_cfs_quota = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 227
Passed tests: 215
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_withoutCpuCfsQuota

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_withoutCpuCfsQuota [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test