Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase range of CloudSQL Query Insights string length & plans per minute to match Enterprise Plus limits #13299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbuck
Copy link
Contributor

@jbuck jbuck commented Mar 9, 2025

After following the docs to increase the CloudSQL Query Insights string length and plan per minute limits we found that the Terraform provider's validation function hasn't been increased to match the new-ish Enterprise Plus limits. This PR modifies the validation function to account for the Enterprise Plus limits.

I see in the Google docs that this is marked as a preview feature. I'm not sure if that means these increased limits should be a beta-only change, or if it's okay to have it in both. I also wonder if changing the validation function based on the edition of the instance is a better idea?

Anyways, let me know what you think and I'm happy to update this PR to match

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

sql: Increased `settings.insights_config.query_string_length` and `settings.insights_config.query_string_length` limits for Enterprise Plus edition `sql_database_instance` resource.

@github-actions github-actions bot requested a review from SirGitsalot March 9, 2025 04:39
Copy link

github-actions bot commented Mar 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 9, 2025
@SirGitsalot
Copy link
Member

/gcbrun

@modular-magician modular-magician added service/sqladmin-cp and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (174 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    insights_config {
      query_plans_per_minute = # value needed
      query_string_length    = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 107
Passed tests: 85
Skipped tests: 21
Affected tests: 1

Click here to see the affected service packages
  • sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSqlUser_password_wo

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants