Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for retrieving a project iam custom role #13302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bestefreund
Copy link
Contributor

Adds a new data source "google_project_iam_custom_role", allowing to retrieve a project iam custom role.

Fixes: hashicorp/terraform-provider-google#21777

Release Note Template for Downstream PRs (will be copied)

`google_project_iam_custom_role`

@github-actions github-actions bot requested a review from ScottSuarez March 10, 2025 07:59
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/iam-core and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 10, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 148 insertions(+))
google-beta provider: Diff ( 4 files changed, 148 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 162
Passed tests: 130
Skipped tests: 30
Affected tests: 2

Click here to see the affected service packages
  • resourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleProjectIamCustomRole_basic
  • TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleProjectIamCustomRole_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data source for retrieving a project iam custom role
2 participants