Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_compute_region_backend_service Datasource #13305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dawid212
Copy link
Contributor

This PR adds a data_source_google_compute_region_backend_service

Related Issues

Release Note

See Write release notes for guidance.

`google_compute_region_backend_service`	

@Dawid212 Dawid212 changed the title Added New datasource Add google_compute_region_backend_service Datasource Mar 10, 2025
@github-actions github-actions bot requested a review from shuyama1 March 10, 2025 10:56
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 10, 2025
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I triggered the tests and I'm working on the review now. Could you add a documentation for this datasource following https://googlecloudplatform.github.io/magic-modules/develop/add-handwritten-datasource/#add-documentation? Thanks

@modular-magician modular-magician added service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 181 insertions(+))
google-beta provider: Diff ( 3 files changed, 181 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1137
Passed tests: 1056
Skipped tests: 79
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceComputeRegionBackendService_basic
  • TestAccDataSourceComputeRegionBackendService_withProject

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceComputeRegionBackendService_basic [Error message] [Debug log]
TestAccDataSourceComputeRegionBackendService_withProject [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add google_compute_region_backend_service data source.
3 participants