Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forward_ssh_connectivity.private_key to be mutable #13307

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ari-hacks
Copy link

@ari-hacks ari-hacks commented Mar 10, 2025

This prevents the connection profile from failing permanently (needing to be re-created) when the forward ssh connectivity private key is updated.
Fixes hashicorp/terraform-provider-google#18999
Related PR #11930

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

datastream: updated `private_key`to be mutable in `google_datastream_connection_profile` resource.

@ari-hacks ari-hacks changed the title Issue 18999 ds ssh connection profile Update forward_ssh_connectivity.private_key to be mutable Mar 10, 2025
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from SirGitsalot March 10, 2025 15:43
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 10, 2025
@SirGitsalot
Copy link
Member

/gcbrun

@modular-magician modular-magician added service/datastream and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 213 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 213 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  forward_ssh_connectivity {
    private_key = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 4
Skipped tests: 8
Affected tests: 1

Click here to see the affected service packages
  • datastream

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDatastreamConnectionProfile_sshKey_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDatastreamConnectionProfile_sshKey_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the private key in forward_ssh_connectivity causes a connection profile replacement
3 participants