Feat/function cloud nat dyna port #13315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
Maarc-D
force-pushed
the
feat/function-cloud-nat-dyna-port
branch
3 times, most recently
from
81129fc to
ce8c038
Compare
Maarc-D
force-pushed
the
feat/function-cloud-nat-dyna-port
branch
from
ce8c038 to
b7a8256
Compare
|
@SirGitsalot can I let you fix the last issue for unit test ? the setup here is a bit mindfuck seems I did not understand something :/ not as easy as a classic provider ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function will help setup correct value for cloud nat dynamic port that must be pow of 2, used here : https://registry.terraform.io/providers/public-cloud-wl/tools/latest/docs/functions/GetClosestInferiorGCPCloudNatDynamicPortFunction
https://github.com/public-cloud-wl/terraform-provider-tools/blob/main/internal/provider/get_closest_inferior_gcp_cloud_nat_dynamic_port_function.go
And I think it is a good idea to backport it here ;)
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.