Add new resource RegionHealthAggregationPolicy to terraform-beta

[jkrish-c]

provider.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_compute_region_health_aggregation_policy` (beta)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 200 insertions(+))
google-beta provider: Diff ( 7 files changed, 1208 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_health_aggregation_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_health_aggregation_policy" "primary" {
  policy_type = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_region_health_aggregation_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1266
Passed tests: 1182
Skipped tests: 83
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionHealthAggregationPolicy_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionHealthAggregationPolicy_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 200 insertions(+))
google-beta provider: Diff ( 7 files changed, 1208 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_health_aggregation_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_health_aggregation_policy" "primary" {
  policy_type = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_region_health_aggregation_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1295
Passed tests: 1210
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionHealthAggregationPolicy_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionHealthAggregationPolicy_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[jkrish-c]

can a reviewer please point me to how to resolve the error "Missing service labels"

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[SirGitsalot]

One nit, otherwise LGTM.

go/fix-missing-service-labels has the instructions. Since your team already owns multiple resources you'll just need to add:

owned_resource: "google_compute_region_health_aggregation_policy"

around line 2906 in enrolled_teams_data.textproto.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 200 insertions(+))
google-beta provider: Diff ( 7 files changed, 1250 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_health_aggregation_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_health_aggregation_policy" "primary" {
  policy_type = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_region_health_aggregation_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1296
Passed tests: 1211
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionHealthAggregationPolicy_computeRegionHealthAggregationPolicyBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionHealthAggregationPolicy_computeRegionHealthAggregationPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 200 insertions(+))
google-beta provider: Diff ( 7 files changed, 1250 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_health_aggregation_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_health_aggregation_policy" "primary" {
  policy_type = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_region_health_aggregation_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1296
Passed tests: 1211
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionHealthAggregationPolicy_computeRegionHealthAggregationPolicyBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionHealthAggregationPolicy_computeRegionHealthAggregationPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test