Skip to content

Conversation

g-dreva
Copy link
Contributor

@g-dreva g-dreva commented Sep 24, 2025

saas_runtime: added `default_release` field to `google_saas_runtime_unit_kind` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 5 files changed, 86 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample [Error message] [Debug log]
TestAccSaasRuntimeUnitKind_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 5 files changed, 86 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample [Error message] [Debug log]
TestAccSaasRuntimeUnitKind_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 5 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • saasruntime

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 5 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample [Error message] [Debug log]
TestAccSaasRuntimeUnitKind_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 5 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample [Error message] [Debug log]
TestAccSaasRuntimeUnitKind_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 5 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample [Error message] [Debug log]
TestAccSaasRuntimeUnitKind_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 5 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample [Error message] [Debug log]
TestAccSaasRuntimeUnitKind_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 5 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample [Error message] [Debug log]
TestAccSaasRuntimeUnitKind_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 15, 2025
@g-dreva g-dreva force-pushed the saasruntime-unitkind-defaultrelease branch from 11c7af1 to 458e803 Compare October 15, 2025 20:47
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 15, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 22 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 105 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 10
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample [Debug log]
TestAccSaasRuntimeUnitKind_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@g-dreva g-dreva marked this pull request as ready for review October 15, 2025 21:09
@github-actions github-actions bot requested a review from ScottSuarez October 15, 2025 21:10
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants