add assistant terraform

[kefang2]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_discovery_engine_assisstant`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1413 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1413 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 280 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 139 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_assistant (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_assistant" "primary" {
  customer_policy {
    model_armor_config {
      failure_mode         = # value needed
      response_template    = # value needed
      user_prompt_template = # value needed
    }
  }
  generation_config {
    default_language = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 27
Skipped tests: 1
Affected tests: 4

Click here to see the affected service packages

• discoveryengine

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample
• TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample_update
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample [Debug log]
TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1413 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1413 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 280 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 139 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_assistant (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_assistant" "primary" {
  customer_policy {
    model_armor_config {
      failure_mode         = # value needed
      response_template    = # value needed
      user_prompt_template = # value needed
    }
  }
  generation_config {
    default_language = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 29
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• discoveryengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1456 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1456 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 290 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 140 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_assistant (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_assistant" "primary" {
  customer_policy {
    model_armor_config {
      failure_mode         = # value needed
      response_template    = # value needed
      user_prompt_template = # value needed
    }
  }
  generation_config {
    default_language = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1456 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1456 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 290 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 140 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_assistant (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_assistant" "primary" {
  customer_policy {
    model_armor_config {
      failure_mode         = # value needed
      response_template    = # value needed
      user_prompt_template = # value needed
    }
  }
  generation_config {
    default_language = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 27
Skipped tests: 1
Affected tests: 4

Click here to see the affected service packages

• discoveryengine

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample
• TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample_update
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 27
Skipped tests: 1
Affected tests: 4

Click here to see the affected service packages

• discoveryengine

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample
• TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample_update
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample [Debug log]
TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample [Debug log]
TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[shuyama1]

Overall looks good. Would it possible to add test coverage on fields listed in #15374 (comment). If not, could you test them locally and confirm that they work? Thanks!

https://googlecloudplatform.github.io/magic-modules/test/run-tests/#optional-test-manually

[kefang2]

The model_armor_config fields actually require valid model armor template resource name. I have added default_language to the unit test and have manually tested model armor template that the API call went through

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1460 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1460 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 290 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 141 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_assistant (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_assistant" "primary" {
  customer_policy {
    model_armor_config {
      failure_mode         = # value needed
      response_template    = # value needed
      user_prompt_template = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 27
Skipped tests: 1
Affected tests: 4

Click here to see the affected service packages

• discoveryengine

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample
• TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample_update
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample [Debug log]
TestAccDiscoveryEngineAssistant_discoveryengineAssistantBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[shuyama1]

The failing tests are unrelated to this change. The model_armor_config fields were confirmed to be working as expected during manual testing #15374 (comment)