promote preview-feature to v1

[hp1100]

Background:

This change promotes the google_compute_preview_feature resource to GA, making it available in the stable provider version. The initial beta support was added in #14363.

compute: promoted the `google_compute_preview_feature` resource to GA.

compute: the `activation_status` attribute within the `google_compute_preview_feature` resource now uses the `ACTIVATION_STATE_UNSPECIFIED` value instead of `DISABLED`. Support for `DISABLED` will be added in a future release.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 495 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 4 files changed, 15 insertions(+), 20 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 110 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_preview_feature

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputePreviewFeature_previewFeatureBasicExample

Tests analytics

Total tests: 1294
Passed tests: 1207
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputePreviewFeature_previewFeatureBasicExample
• TestAccComputePreviewFeature_update
• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputePreviewFeature_previewFeatureBasicExample [Error message] [Debug log]
TestAccComputePreviewFeature_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 495 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 4 files changed, 15 insertions(+), 20 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 110 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_preview_feature

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputePreviewFeature_previewFeatureBasicExample

Tests analytics

Total tests: 1294
Passed tests: 1208
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputePreviewFeature_previewFeatureBasicExample
• TestAccComputePreviewFeature_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputePreviewFeature_previewFeatureBasicExample [Debug log]
TestAccComputePreviewFeature_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[ScottSuarez]

teamcity stub - https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_COMPUTE/500085

[ScottSuarez]

  - name: 'activationStatus'
    type: String
    description: 'The activation status of the preview feature. Possible values: ["ENABLED", "ACTIVATION_STATE_UNSPECIFIED"]'
    required: true
    validation:
      function: verify.ValidateEnum([]string{"ENABLED", "DISABLED", "ACTIVATION_STATE_UNSPECIFIED"})

My recommendation would be this implementation. Enums are really just strings with some validation. This way we still support the previous enum at the validation level and simply remove it from documentation.

[ScottSuarez]

checked test history. Also failing there
https://hashicorp.teamcity.com/test/2895556846449536514?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_BETA_NIGHTLYTESTS . I believe we can make this change safely.

No external calls in last 30 days
https://plx.corp.google.com/scripts2/script_6b._e0b5c0_eb8e_45b2_a8bc_ff67878d3e7d