Skip to content

Conversation

Berro321
Copy link
Contributor

beyondcorp: made `ports` field in `endpointMatchers` required.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field endpoint_matchers.ports changed from optional to required on google_beyondcorp_security_gateway_application - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 18 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 18 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field endpoint_matchers.ports changed from optional to required on google_beyondcorp_security_gateway_application - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 31
Skipped tests: 4
Affected tests: 9

Click here to see the affected service packages
  • beyondcorp

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 31
Skipped tests: 4
Affected tests: 9

Click here to see the affected service packages
  • beyondcorp

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@Berro321 Berro321 marked this pull request as ready for review October 14, 2025 20:14
@github-actions github-actions bot requested a review from SirGitsalot October 14, 2025 20:15
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants