Skip to content

Conversation

jessdejong
Copy link
Member

Description: Set the Crypto Key IAM binding on the service account prior to the Managed Kafka cluster creation.

Issue: https://buganizer.corp.google.com/issues/447698012

managedkafka: fix the order of cluster creation and IAM binding in CMEK test.

@github-actions github-actions bot requested a review from melinath October 14, 2025 20:22
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 2 files changed, 8 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 10
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • managedkafka

🟢 All tests passed!

View the build log

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CryptoKeys can cause test failures because they're not actually deleted. I'd recommend reworking this test to use a bootstrapped CryptoKey. You could also bootstrap the required IAM permissions, but I'm pretty sure they should already be granted at the project level by other tests.

@github-actions github-actions bot requested a review from melinath October 16, 2025 17:09
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 26 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 52 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • managedkafka

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaCluster_managedkafkaClusterCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaCluster_managedkafkaClusterCmekExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants