Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #467

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Update CODEOWNERS #467

merged 3 commits into from
Nov 12, 2024

Conversation

jiangjy1982
Copy link
Collaborator

As title.

RissyRan
RissyRan reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@RissyRan RissyRan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see jfacevedo-google has pending invitation, and this file reports error. Not sure before Juan accepts the invite, this file can work functionally after the merge. Can anyone confirm? If not, can we add him later?

RissyRan
RissyRan approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jiangjy1982 jiangjy1982 merged commit 9d76c42 into master Nov 12, 2024
6 checks passed
@jiangjy1982 jiangjy1982 deleted the jet branch November 12, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gobbleturk gobbleturk gobbleturk approved these changes

@RissyRan RissyRan RissyRan approved these changes

@shralex shralex shralex approved these changes

@michelle-yooh michelle-yooh Awaiting requested review from michelle-yooh

@allenwang28 allenwang28 Awaiting requested review from allenwang28 allenwang28 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiangjy1982 @shralex @RissyRan @gobbleturk