Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(run-helloworld): updating type in package.docs.json #3624

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix(run-helloworld): updating type in package.docs.json #3624

merged 1 commit into from
Feb 14, 2024

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Feb 14, 2024 •
edited
Loading

Description

Reflect change to from csm to esm in https://cloud.google.com/run/docs/quickstarts/build-and-deploy/deploy-nodejs-service.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@pattishin pattishin requested review from a team as code owners February 14, 2024 19:37
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. labels Feb 14, 2024
@pattishin pattishin changed the title fix(run-helloworld): adding in type:module in package.docs.json fix(run-helloworld): updating type in package.docs.json Feb 14, 2024
NimJay
NimJay approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks, @pattishin, for this fix.

I wonder where else we might have this issue.

Approved.

@pattishin pattishin merged commit 67909a4 into main Feb 14, 2024
30 checks passed
@pattishin pattishin deleted the fix/run-helloworld-module branch February 14, 2024 19:46
pattishin added a commit that referenced this pull request Feb 15, 2024
@pattishin
fix: adding in type:module in package.docs.json (#3624)
306e5a9 
chore: attempt to fix linting errors

chore: attempt to fix linting errors

chore: attempt to lint functionCallingStreamChat

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent
pattishin added a commit that referenced this pull request Feb 15, 2024
@pattishin
fix: adding in type:module in package.docs.json (#3624)
c9407b0 
chore: attempt to fix linting errors

chore: attempt to fix linting errors

chore: attempt to lint functionCallingStreamChat

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent
pattishin added a commit that referenced this pull request Feb 15, 2024
@pattishin
fix: adding in type:module in package.docs.json (#3624)
c8d11ea 
chore: attempt to fix linting errors

chore: attempt to fix linting errors

chore: attempt to lint functionCallingStreamChat

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent
pattishin added a commit that referenced this pull request Feb 15, 2024
@LukeSchlangen @gericdong
@pattishin @glaforge
chore: remove .preview from generative ai methods (#3620)
72026d7 
* chore: remove .preview from generative ai methods

chore: update ai package versions

fix: fix broken tests

fix: update dependency to use github over npm

feat: change assertion to more common output

added function calling examples

removed double await, fix linter

* feat: readd GenAI embedding code samples (#3616)

Co-authored-by: Patti Shin <[email protected]>

* fix: adding in type:module in package.docs.json (#3624)

chore: attempt to fix linting errors

chore: attempt to fix linting errors

chore: attempt to lint functionCallingStreamChat

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

chore: lint functionCallingStreamContent

* fix: Attempt at pleasing the Linter (#3625)

* Attempt at pleasing the Linter

* fix(linter): trying to please CI

---------

Co-authored-by: Patti Shin <[email protected]>

* fix: lint

---------

Co-authored-by: Eric Dong <[email protected]>
Co-authored-by: Patti Shin <[email protected]>
Co-authored-by: Guillaume Laforge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

Assignees

@glasnt glasnt

Labels
api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pattishin @NimJay @glasnt