Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nextjs sample #3627

Closed
wants to merge 16 commits into from
Closed

feat: add nextjs sample #3627

wants to merge 16 commits into from

Conversation

LukeSchlangen
Copy link
Member

@LukeSchlangen LukeSchlangen commented Feb 20, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@LukeSchlangen LukeSchlangen added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 20, 2024
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. labels Feb 20, 2024
@LukeSchlangen LukeSchlangen removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 21, 2024
@LukeSchlangen LukeSchlangen marked this pull request as ready for review February 21, 2024 03:00
@LukeSchlangen LukeSchlangen requested review from a team as code owners February 21, 2024 03:00
Copy link

snippet-bot bot commented Feb 21, 2024

Here is the summary of possible violations 😱

There are 2 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@LukeSchlangen
Copy link
Member Author

This is likely not the right place for this code. Thanks for sharing this next.js demo with me @glasnt! I'll use that instead.

@grayside grayside deleted the feature/nextjs-helloworld branch July 18, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants