Skip to content

feat(generative-ai): Add PDF sample for Gemini 1.5 #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2024
Merged

feat(generative-ai): Add PDF sample for Gemini 1.5 #3665

merged 4 commits into from
Apr 26, 2024

Conversation

gericdong
Copy link
Contributor

Description

Fixes b/330500909

Add PDF code sample for Gemini 1.5 Pro.

@gericdong gericdong requested review from a team as code owners April 23, 2024 01:23
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Apr 23, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: genai labels Apr 23, 2024
@holtskinner
Copy link
Contributor

I wonder if @google-cloud/aiplatform in package.json needs to be updated to the latest version 3.19.0? Might be part of the reason for the test failures?

holtskinner
holtskinner reviewed Apr 23, 2024
View reviewed changes
generative-ai/snippets/test/gemini-pdf.test.js

describe('Analyze PDF document', async () => {
it('should analyze PDF document', async () => {
const output = execSync(`node ./gemini-pdf.js ${projectId}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like the function returns anything, so this test would fail. Unless the output for this testing structure is just the console.log() output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good point. I reran the test and confirmed that the test was able to validate the std output of the sample. I think we should be Ok.

@pattishin pattishin merged commit 1461f47 into main Apr 26, 2024
30 of 31 checks passed
@pattishin pattishin deleted the b330500909 branch April 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattishin pattishin pattishin approved these changes

@holtskinner holtskinner holtskinner approved these changes

Assignees
No one assigned
Labels
api: genai samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gericdong @holtskinner @pattishin