Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(endpoints): Update region tag #4020

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Mar 6, 2025

Description

Fixes b/401227018

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners March 6, 2025 15:17
Copy link

snippet-bot bot commented Mar 6, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples. labels Mar 6, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hivanalejandro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the region tag in openapi-appengine.yaml. It adds a copyright notice at the beginning of the file and wraps the swagger definition with region tags [START endpoints_swagger_appengine_yaml_nodejs] and [END endpoints_swagger_appengine_yaml_nodejs].

Highlights

  • Region Tag Update: The primary change involves updating the region tag in the openapi-appengine.yaml file to properly encapsulate the Swagger definition.
  • Copyright Notice: A copyright notice has been added to the beginning of the openapi-appengine.yaml file.

Changelog

  • endpoints/getting-started/openapi-appengine.yaml
    • Added a copyright notice at the beginning of the file.
    • Wrapped the Swagger definition with region tags [START endpoints_swagger_appengine_yaml_nodejs] and [END endpoints_swagger_appengine_yaml_nodejs].
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


In YAML files, configurations reside,
Region tags help, code to divide.
Copyright's there, a legal embrace,
Ensuring clarity, in every space.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the region tag in openapi-appengine.yaml. The changes add a copyright notice and update the start and end tags for the swagger section. The addition of the copyright notice is good practice. The update to the region tags appears correct.

Merge Readiness

The pull request appears to be in good shape for merging. The changes are straightforward and address the intended issue. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.

Comment on lines 1 to 12
# Copyright 2025 Google LLC
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright header includes the year 2025. Please confirm that this is the correct year, and update if necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a new sample so the copyright shouldn't be 2025 but the original file year

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an update to the copyright header; year should be the creation of file and not this year.

@hivanalejandro hivanalejandro requested a review from iennae March 6, 2025 18:41
@hivanalejandro hivanalejandro merged commit be25b32 into main Mar 10, 2025
12 checks passed
@hivanalejandro hivanalejandro deleted the hivanalejandro-update-region-step1-401227018 branch March 10, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants