Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old workflows for migrated samples #4026

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Mar 11, 2025

Description

An additional step when migrating samples to the new CI is to remove the old configs (if they exist)

  • Please merge this PR for me once it is approved

@glasnt glasnt requested review from a team as code owners March 11, 2025 23:54
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Mar 11, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request removes outdated workflow configurations for samples that have been migrated to the new CI. Specifically, it deletes the following files: .github/workflows/appengine-analytics.yaml, .github/workflows/appengine-metadata-flexible.yaml, .github/workflows/recaptcha-enterprise.yaml, and .github/workflows/scheduler.yaml. The PR description indicates that this is a standard cleanup step following the migration of samples to the new CI.

Highlights

  • Workflow Removal: This pull request removes four workflow configuration files (.github/workflows/*.yaml) that are no longer needed due to the migration of their respective samples to a new CI system.
  • Cleanup: The PR serves as a cleanup task, ensuring that the repository doesn't retain obsolete configurations, which could lead to confusion or unintended behavior.

Changelog

  • .github/workflows/appengine-analytics.yaml
    • File removed: This file contained the workflow configuration for the appengine-analytics sample, which is no longer needed after migration to the new CI.
  • .github/workflows/appengine-metadata-flexible.yaml
    • File removed: This file contained the workflow configuration for the appengine-metadata-flexible sample, which is no longer needed after migration to the new CI.
  • .github/workflows/recaptcha-enterprise.yaml
    • File removed: This file contained the workflow configuration for the recaptcha-enterprise sample, which is no longer needed after migration to the new CI.
  • .github/workflows/scheduler.yaml
    • File removed: This file contained the workflow configuration for the scheduler sample, which is no longer needed after migration to the new CI.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A workflow's tale, now at its end,
Its purpose served, its cycles bend.
Migrated code, a newer stage,
The old config, turns a page.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes old workflow configurations, which is a necessary step in migrating samples to the new CI. The changes seem straightforward and address the intended purpose.

Merge Readiness

The pull request appears to be ready for merging, as it removes the specified workflow files as intended. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.

Copy link
Member

@briandorsey briandorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@briandorsey briandorsey merged commit dfc9414 into main Mar 12, 2025
11 checks passed
@briandorsey briandorsey deleted the glasnt-old-workflows branch March 12, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants