Testing: Simplify UploadContent on linux #1637
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is effectively undoing cl/378416757, because
RunRemotelyStdin
has been fixed (#1636) to handle large stdin values.This PR also adds some tests for
UploadContent
, including a test that failed prior to #1636 (but passes now).This PR also changes the contract of
UploadContent
to no longer automatically create enclosing directories; instead the burden of doing that has been moved to the caller. Only one callsite needed to be fixed, though that required implementing a new functionmakeParentDirectory
inops_agent_test.go
.The net effect of this PR is that:
UploadContent
doesn't depend on InstallGsutilIfNeeded anymoreUploadContent
doesn't use GCS orTRANSFERS_BUCKET
on linux anymoreInstallGsutilIfNeeded
can move out of the core gce_testing.go library into the agents library, the only place that it is still used.Related issue
cleanup
How has this been tested?
automated tests passed, plus I ran
gce_testing_test.go
manually, also passing.Checklist: