Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transformation test make target and docs #1722
base: master
Are you sure you want to change the base?
Add transformation test make target and docs #1722
Changes from 15 commits
f7aecdd
33a760b
73e5155
79127e9
dbb99ab
91c0397
cfcc68f
a4b98df
65cfc75
f1d154e
e87fa1e
0572082
6d2aeac
34654d8
e1164e0
78fbf64
b94c571
ea76294
c66ca2d
4ed4297
d0194ea
0800d03
0db4c79
eb5d8ef
2853765
6e0c84a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Optional] These quotes are also superfluous (but harmless).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, these flags didn't use to have quotes on the command line, so it may make sense to not use quotes in the array as well… Except, maybe, for
CMAKE_INSTALL_PREFIX
, which could become-DCMAKE_INSTALL_PREFIX="$fluent_bit_dir"
… WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Optional] I wonder if we should be calling it
developer_tasks.mak
or something…There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally chose
tasks.mak
just cause it was shorter, and at first it seemed like we'd need to always type in-f tasks.mak
so making it longer would have been a pain. We could change it now, though it really only exists to then be immediately symlinked to when you set up your environment.