Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confgenerator: add NFS path detection #1802

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

confgenerator: add NFS path detection #1802

wants to merge 2 commits into from

Conversation

braydonk
Copy link
Contributor

@braydonk braydonk commented Sep 24, 2024

Description

This draft PR shows adding detection to the Ops Agent for NFS include paths in the file receiver. Since NFS does not support inotify, the Ops Agent would detect the include paths from the config and if one of the include paths for that receiver is an NFS directory, it switches that tail plugin to use the fstat backend instead of inotify.

Related issue

b/369376689

How has this been tested?

All testing of this was done manually on a system with an NFS mounted directory. TODO: add an integration test that automates the environment I was using to test this manually.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@braydonk braydonk marked this pull request as draft September 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant