Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated goccy/go-yaml to v.14.1 #1829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated goccy/go-yaml to v.14.1 #1829

wants to merge 2 commits into from
+44 −46

Conversation

XuechunHou
Copy link
Contributor

@XuechunHou XuechunHou commented Nov 13, 2024 •
edited
Loading

Description

Updated goccy/go-yaml to v.14.1 by executing the command go get -u github.com/goccy/[email protected]

Related issue

b/376658816

How has this been tested?

Checklist:

  • Unit tests
    • [] Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@XuechunHou XuechunHou force-pushed the xuechun-go-yaml branch 4 times, most recently from 2098039 to 11063ed Compare November 13, 2024 22:44
braydonk
braydonk reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Looks like there is a breaking change in the pretty printing that this PR caught. I'm going to open an issue upstream about this. Our update can be on hold until then.

@braydonk
Copy link
Contributor

Opened goccy/go-yaml#534

@braydonk
Copy link
Contributor

braydonk commented Nov 14, 2024 •
edited
Loading

@XuechunHou The upstream issue has been resolved. Can you update the package to v1.14.1 and update the goldens?

@XuechunHou XuechunHou changed the title Updated goccy/go-yaml to v.13.1 Updated goccy/go-yaml to v.14.1 Nov 14, 2024
@XuechunHou XuechunHou added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braydonk braydonk braydonk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuechunHou @braydonk @stackdriver-instrumentation-release