feat(tests): use a single container with multiple php versions #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
bshaffer
added
kokoro:run-all
google-cla
bot
added
the
cla: yes
bshaffer
added
the
do not merge
…rm/php-docs-samples into use-multiphp-container
product-auto-label
bot
added
the
samples
…rm/php-docs-samples into use-multiphp-container
…les into use-multiphp-container
| @@ -3,7 +3,7 @@ | |||
| # Configure the docker image for kokoro-trampoline. | |||
| env_vars: { | |||
| key: "TRAMPOLINE_IMAGE" | |||
| value: "gcr.io/cloud-devrel-kokoro-resources/php80" | |||
| value: "gcr.io/cloud-devrel-kokoro-resources/php-multi-test" | |||
There was a problem hiding this comment.
I cannot find it here: https://github.com/googleapis/testing-infra-docker/blob/main/php/php80/Dockerfile
Is it located somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to eventually break the tests down by sample directory instead of by PHP version. This will greatly simplify the complexity of our testing and speed up test execution.
/cc @ace-n