-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook to quickly generate and load embeddings in AlloyDB. #12588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
shweta345
reviewed
Sep 13, 2024
…o app. Remove unnecessary imports.
kurtisvg
suggested changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick issues I see while reviewing:
P0s:
- The code is not tested (which is required to merge)
- Versions installed w/ pip should be pinned to prevent issues with updates
- We should update to load data from a file -- either a file in this repo or a public GCS bucket to streamline implementation
P1s:
- We should be using type hints
- User inputs should be streamlined to not rely on Secret Manager -- something like the "Set up alloyDB" section here would be preferred
- We should evaluate using asyncio -- much of this is blocked on I/O, may speed it up considerably to operate in parallel
- Need to evaluate failure for vertex AI quota issues
P2s:
- Should consider using a generator for a batching function (python best practice)
- We may also want to consider using the AlloyDB Python Connector here for mTLS + make execution in the codelab better
6 tasks
Closed in favour of #12721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: notebooks
Issues related to the Vertex AI Workbench API.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AlloyDB Embeddings Notebook
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.12
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)