Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run/django): Update to Procfile, Artifact Registry, dedicated service account #12718

Merged
merged 23 commits into from
Nov 14, 2024

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Oct 22, 2024

Description

Fixes b/364075989, cl/688789319

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Oct 22, 2024
@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2024
@glasnt glasnt marked this pull request as ready for review October 23, 2024 23:45
@glasnt glasnt requested review from a team as code owners October 23, 2024 23:45
Copy link

snippet-bot bot commented Oct 23, 2024

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2024
@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2024
@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2024
@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2024
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2024
@glasnt
Copy link
Contributor Author

glasnt commented Oct 30, 2024

Blocked on cl/691542544 to pin region tag that is being deprecated.

@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2024
@glasnt glasnt added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 31, 2024
@glasnt glasnt marked this pull request as draft October 31, 2024 01:13
@glasnt glasnt marked this pull request as ready for review October 31, 2024 01:13
@glasnt
Copy link
Contributor Author

glasnt commented Oct 31, 2024

I can't seem to re-run snippetbot here :(

Update: Oh there it goes!

@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 31, 2024
- "-c"
- |
./retry.sh "docker build -t gcr.io/${PROJECT_ID}/${_SERVICE}:${_VERSION} ."
name: gcr.io/k8s-skaffold/pack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this look like it's deprecated/unsupported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the one currently listed on https://cloud.google.com/docs/buildpacks/build-application#build_an_application_remotely

If that changes, we should promptly update all samples that uses the old image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try the (probable) replacement "buildpacksio/pack", as this seems to work in isolation.

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the thorough update.

@glasnt glasnt merged commit 506c933 into main Nov 14, 2024
14 checks passed
@glasnt glasnt deleted the django-jobs branch November 14, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants