-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(run/django): Update to Procfile, Artifact Registry, dedicated service account #12718
Conversation
Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Blocked on cl/691542544 to pin region tag that is being deprecated. |
I can't seem to re-run snippetbot here :( Update: Oh there it goes! |
run/django/e2e_test_setup.yaml
Outdated
- "-c" | ||
- | | ||
./retry.sh "docker build -t gcr.io/${PROJECT_ID}/${_SERVICE}:${_VERSION} ." | ||
name: gcr.io/k8s-skaffold/pack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this look like it's deprecated/unsupported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the one currently listed on https://cloud.google.com/docs/buildpacks/build-application#build_an_application_remotely
If that changes, we should promptly update all samples that uses the old image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try the (probable) replacement "buildpacksio/pack", as this seems to work in isolation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for the thorough update.
Description
Fixes b/364075989, cl/688789319
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)