-
Notifications
You must be signed in to change notification settings - Fork 16
Time-sync config example #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ferrarimarco
merged 6 commits into
GoogleCloudPlatform:master
from
shacharr-google:master
Oct 22, 2025
Merged
Time-sync config example #55
ferrarimarco
merged 6 commits into
GoogleCloudPlatform:master
from
shacharr-google:master
Oct 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa6efb5 to
58e27f4
Compare
ferrarimarco
requested changes
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for this PR. A few things to check :)
9229697 to
fb7d036
Compare
Script for setting up logging and creating an accuracy dashboard for accurate time for Compute Engine VMs (GCE version using ops-agent, to contrast with the GKE version following).
fb7d036 to
6ce0035
Compare
Adds scripts for creating a VM with accurate time. Following commit will demonstrate converting this VM creation flow to GKE daemonset
Explain what the time-sync-example folder is demonstrating, to help our readers' orientation.
6ce0035 to
87f05f9
Compare
a4557ac to
73689a5
Compare
Help our readers understand what this example is demonstrating and how to use the scripts. Currently only documenting the GCE portion, with GKE version to follow shortly.
73689a5 to
435b111
Compare
ferrarimarco
requested changes
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things to check.
This commit adds a daemonset which is the counterpart of the compute engine scripts found in the gce folder. It is creating a GKE cluster with chrony and PTP-KVM enabled clock synchronization, waiting until chrony is synchronized before allowing workload to run on the node.
Document the added GKE scripts for TimeSync in README.md. Explain the expected usage and the high level role of each script.
435b111 to
5768863
Compare
ferrarimarco
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample scripts for timesync configuration in single VM configuration, to compare and contrast with the GKE DaemonSet variation of the example to follow