privateca: update certificate authority samples with more realistic values #3054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues (#12259) Signed-off-by: Sven Hoexter <[email protected]> [upstream:27812e087aaf4250c076b5d572b3934c1a013e2e] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
iyabchen
and removed request for
a team
modular-magician
deleted the
downstream-pr-27812e087aaf4250c076b5d572b3934c1a013e2e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the properties configured here are either wrong or at least not very sensible on root certificates / subordinates.
A similar set of fixes got applied to terraform documentation samples in terraform-google-modules/terraform-docs-samples#631
What is left out here is placing the subordinate CA in it's own pool. I could not figure out what is required here to prepare the test infrastructure to provision another pool dedicated to the sub-ca. Technically those two certificates should not reside in the same pool.
Derived from GoogleCloudPlatform/magic-modules#12259