-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update common util #3868
Update common util #3868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rayandasoriya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the common_util.py
file in the notebook_util
directory. It adds a new GPU type, NVIDIA_H100_MEGA_80GB
, to the get_resource_id
function's dictionary, mapping it to the resource ID nvidia_h100_mega_gpus
. Additionally, it introduces a new function, get_deploy_source
, which determines the deployment source based on the VERTEX_PRODUCT
environment variable, returning specific strings for 'COLAB_ENTERPRISE' and 'WORKBENCH_INSTANCE' environments, and a default string for unspecified environments.
Highlights
- GPU Resource ID Mapping: The pull request adds a mapping for the
NVIDIA_H100_MEGA_80GB
GPU to its corresponding resource ID,nvidia_h100_mega_gpus
. - Deployment Source Detection: A new function,
get_deploy_source
, is introduced to dynamically determine the deployment environment (e.g., Colab Enterprise, Workbench) based on theVERTEX_PRODUCT
environment variable.
Changelog
- community-content/vertex_model_garden/model_oss/notebook_util/common_util.py
- Added
NVIDIA_H100_MEGA_80GB
to theget_resource_id
function's GPU mapping. - Implemented the
get_deploy_source
function to identify the deployment environment.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The first GPU was the GeForce 256, released by NVIDIA in 1999.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates a common utility function to include a new accelerator type and adds a function to determine the deployment source based on the environment. The changes seem straightforward and address the intended functionality.
Merge Readiness
The changes appear to be well-implemented and address the intended functionality. I don't see any critical or high severity issues, and the code seems ready to be merged. However, I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.
Update common util
Community Notebooks
under the notebooks/community folder:Community Notebooks
section, pointing to the author or the author's team.