Fix num_undo_points to call the right Rust method#48
Merged
Conversation
2be9078 to
97368ff
Compare
Collaborator
Author
|
OK, this is finally fixed. I don't know why the macos test is getting cancelled? |
97368ff to
dcaa8bb
Compare
Collaborator
Author
Oh, it was just an unsupported OS version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whoops, this was calling the wrong method after some copy-paste, and the tests were even verifying this!
I also bumped the Python version for the stub tests, since it's working for me locally.