php72, download utf8 filename#50
Open
mytory wants to merge 1 commit into
Open
Conversation
|
@Grandt There are some fixes/improvements in other forks too. Do you think you will merge them too? Thanks. |
|
@Daniel-KM last activity of @Grandt was in 2016 year. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1
php 7.2 deprecated each function. And Laravel framework doesn't permit deprecated function. I've intended to use this project in my Laravel project, but the framework throw ErrorException.
So, I changed all
each()function toforeach()control structure.2
$book->sendBook($download_filename);this code does not pass$utf8filenameparameter tosendZipfunction. So I added an argument(2287 line inPHPePub\Core\Epub).Thanks.