Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Pen tool #2452

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

0SlowPoke0
Copy link
Contributor

@0SlowPoke0 0SlowPoke0 commented Mar 17, 2025

Part of #1870

Added features:

  • Tab swaps to dragging the opposite handle (native: teleports the cursor / web: enters pointer lock and draws a fake cursor at the new location)

  • If the current segment is closing the shape by connecting to its start point, the handle that's being dragged should be the closing handle, not a fake handle on the opposite side, and all the above shortcuts should work on that anchor/handle group spanning the start/end point (Tab will modify the shape of the first segment while the current/final segment is still in-progress)

  • Holding Ctrl while closing a path now locks the end handle to the angle of the opposite handle of the endpoint.

Other issues fixed:

  • When joining paths, switching between them, and clicking the handles of joined endpoints, the opposite handles now correctly:

    Screen-Recording.3.mp4
  • Handles that appeared colinear but were not when using the path tool and dragging are now displayed correctly.

  • When dragging a handle from the start of the segment and aborting the GRS it moves the end handle of segment:

    Screen-Recording.6.mp4
  • fixed bug

@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review March 20, 2025 03:24
@0SlowPoke0 0SlowPoke0 marked this pull request as draft March 21, 2025 08:31
@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review March 27, 2025 16:29
@0SlowPoke0 0SlowPoke0 changed the title Pen refactor Improving Pen tool Mar 27, 2025
@Keavon
Copy link
Member

Keavon commented Mar 28, 2025

!build

Copy link

📦 Build Complete for 3a73690
https://d8bf6eec.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Mar 28, 2025

  • Drawing a brand new path with the Pen tool, when I'm dragging from the initial point in my first mousedown, shouldn't let Tab work because there is no opposite handle to swap to.

  • Holding Ctrl while closing a path now locks the end handle to the angle of the opposite handle of the endpoint.

    This has a few edge cases, here's a webcast with audio explaining them.

@Keavon
Copy link
Member

Keavon commented Mar 30, 2025

!build

Copy link

📦 Build Complete for 5b1ba81
https://c5ffedea.graphite.pages.dev

@Keavon Keavon force-pushed the master branch 4 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants