Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert point when hovering on segment + Ctrl click to delete segment #2495

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

4adex
Copy link
Contributor

@4adex 4adex commented Mar 28, 2025

Part of #1870

When clicking a segment (new since video was recorded):

  • Clicking without any modifier key should split the segment where clicked. Currently this has the extra complication of entering an insertion mode where the point of the segment split can be slid within the segment and left click confirms it while right click cancels. We want to remove that extra step and just insert directly. An overlay should be drawn in cases where the cursor is hovered over the segment such that clicking would insert a split, it should be a short line segment (20px in diameter) running perpendicular to the curve.

  • Ctrl clicking should delete the segment that's clicked. Currently a user would have to split the segment then delete the newly created point.

@4adex 4adex marked this pull request as ready for review March 31, 2025 10:32
@4adex 4adex changed the title Segment hover, clicking and Ctrl + click Insert point when hovering on segment + Ctrl click to delete segment Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant