-
-
Notifications
You must be signed in to change notification settings - Fork 963
Disallow invalid layer reorder placements as siblings of artboards #3289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Disallow invalid layer reorder placements as siblings of artboards #3289
Conversation
|
Upon watching your video demo, I realized that the ideal behavior will be rejecting the placement opportunity in places that are siblings of artboards (generalized to be describable as "invalid placements"). This would need to be given to the frontend by the backend, or maybe better, answered by the backend in response to a query by the frontend. This way, we never show the white insertion line of a width that would indicate an invalid placement, which is a flaw of this "just correct it if it's invalid" approach that I realized now. |
makes sense. |
|
I'd suggest iterating on this PR with the suggested change of approach. No need to open a separate PR. |
Can you tell me more clearly what i need to implement? got little confused. and what about the feat for which pr is raised ? |
|
This PR. I'm suggesting you keep working on changes to it to implement my described updated approach (from my first comment in this discussion). |
Yes but what about dropping on bottom, should I consider it as valid or invalid now? |
|
I'm not understanding the question. All invalid drop locations shouldn't be valid white horizontal line placements, thus pre-filtering instead of post-rejecting. |
Ok so you mean dropping a layer as artboard sibling should be invalid? and currently if we try to do that we do see white line indicating its valid drop even though its invalid |
|
Correct. |
89aaa5e to
1ab4d41
Compare
510f06e to
2a61db5
Compare
|
Demo: Graphite.and.7.more.pages.-.Personal.2.-.Microsoft_.Edge.2025-10-25.22-37-17.mp4 |
|
Hey @Keavon you can have a look |
|
Your video seems to show the line jumping around and appearing in places rather erratically. Please pay attention to small details like that and ensure it's behaving how it should. Happy to take another look at a video with your next shot (and thanks for making it easy with the video recording for me). Thanks. |
Closes #3256
Demo:
Graphite.-.Personal.2.-.Microsoft_.Edge.2025-10-15.20-04-11.mp4