You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, great to see it compiling and running!
The window decoration buttons look a bit weird.
This is with the window not selected (This normally makes these buttons all grey on macos when the window isn't selected)
This is with the window selected.
So it seems that the offset of the buttons are a bit off and macos is still rendering buttons in the background.
So it seems that the offset of the buttons are a bit off and macos is still rendering buttons in the background.
You are right, currently we have both the native buttons and the ones we draw as part of the ui displayed. The Native buttons will stay,and our custom ones will go, that will be done in a future PR.
The bigger issue is actually scaling right now.
On my device this looks like this (double buttons are also more apparent)
Keavon
changed the title
Desktop: Bundle for MacOS and Windows
Desktop: Bundle for Mac and Windows
Oct 21, 2025
Does npm run start-desktop still work on Windows after this pr?
I still don't like that we have different crates for the final binary dependent on the platform
Does npm run start-desktop still work on Windows after this pr? I still don't like that we have different crates for the final binary dependent on the platform
Yes, the main binary will, and in my opinion should, work on all platforms (on mac you would just be missing the dependencies).
I still prefer it that way because we don't have to mix platform specific build scripts (linking) and those entry points will just call start (nothing else they can do), Would you like me to leave a big comment about that at the top of the files?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #3295
run to test bundle
cargo run -p graphite-desktop-bundle -- open
Linux bundling is not yet implemented.
npm run start-desktop
works for all platforms.