Skip to content

Fix RelativeDirection not treating EnumFacing#DOWN properly #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MCTian-mi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix RelativeDirection not treating EnumFacing#DOWN properly #2848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48368f5
fix: fix RelativeDirection not treating EnumFacing#DOWN properly
MCTian-mi Aug 10, 2025
9756293
Merge branch 'master' into relative-dir
MCTian-mi Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/gregtech/api/util/RelativeDirection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,10 @@ yield switch (upwardsFacing) {
}
case LEFT -> {
EnumFacing facing;
if (frontAxis == Axis.Y) {
if (frontFacing == EnumFacing.UP) {
facing = upwardsFacing.rotateY();
} else if (frontFacing == EnumFacing.DOWN) {
facing = upwardsFacing.rotateYCCW();
} else {
facing = switch (upwardsFacing) {
case NORTH -> frontFacing.rotateYCCW();
Expand All @@ -84,8 +86,10 @@ yield switch (upwardsFacing) {
}
case RIGHT -> {
EnumFacing facing;
if (frontAxis == Axis.Y) {
if (frontFacing == EnumFacing.UP) {
facing = upwardsFacing.rotateYCCW();
} else if (frontFacing == EnumFacing.DOWN) {
facing = upwardsFacing.rotateY();
} else {
facing = switch (upwardsFacing) {
case NORTH -> frontFacing.rotateY();
Expand Down
Loading