Skip to content

docs: remove "mode" from db configuration #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Conversation

MichaelScofield
Copy link
Contributor

What's Changed in this PR

close #1712

Checklist

  • Please confirm that all corresponding versions of the documents have been revised.
  • Please ensure that the content in sidebars.ts matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other files which contain this option:

~/Documents/greptime-docs/docs (main ✗) ag mode | grep "mode = " |grep stand
user-guide/protocols/http.md:123:mode = "standalone"
user-guide/deployments/configuration.md:625:mode = "standalone"
reference/telemetry.md:36:mode = "standalone"
~/Documents/greptime-docs/docs (main ✗) ag mode | grep "mode = " |grep distributed
user-guide/deployments/configuration.md:619:mode = "distributed"

Copy link

cloudflare-workers-and-pages bot commented May 6, 2025

Deploying greptime-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 545fbc5
Status: ✅  Deploy successful!
Preview URL: https://542c16be.greptime-docs.pages.dev
Branch Preview URL: https://docsremove-mode-from-config.greptime-docs.pages.dev

View logs

@MichaelScofield
Copy link
Contributor Author

There are other files which contain this option:

~/Documents/greptime-docs/docs (main ✗) ag mode | grep "mode = " |grep stand
user-guide/protocols/http.md:123:mode = "standalone"
user-guide/deployments/configuration.md:625:mode = "standalone"
reference/telemetry.md:36:mode = "standalone"
~/Documents/greptime-docs/docs (main ✗) ag mode | grep "mode = " |grep distributed
user-guide/deployments/configuration.md:619:mode = "distributed"

removed

Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 merged commit 1136b88 into main May 8, 2025
5 checks passed
@sunng87 sunng87 deleted the docsremove-mode-from-config branch May 8, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for refactor: remove the "mode" configuration item completely
4 participants