fix: webhook server initialization #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbzweihander
changed the title
Signed-off-by: pbzweihander <[email protected]>
pbzweihander
force-pushed
the
webhook
branch
from
fd25576 to
661c21e
Compare
|
It worked before, probably due to an upgrade of controller-runtime package. I think we should add some tests to cover it. |
|
Thank you. @pbzweihander |
Signed-off-by: pbzweihander <[email protected]>
|
Added error handling |
pbzweihander
force-pushed
the
webhook
branch
from
d6418d8 to
3b3c76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not understand how controller-runtime works, but it seems like the webhook server does not start if you not use
Manager.Addmethod.In current upstream branch, if you run
go run cmd/operator/main.go --enable-admission-webhook, the webhook server does not start.