-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: construct show index
results through table schema
#5741
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Zhenchi <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: Zhenchi <[email protected]>
cardinalities.push(None); | ||
sub_parts.push(None); | ||
packeds.push(None); | ||
nullables.push(Some(if nullable { YES_STR } else { "" })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to refactor in this way? In fact, |
Some column schema information, I did not find a suitable placement in the |
We can extend the table columns just like https://docs.greptime.com/reference/sql/information-schema/partitions |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Construct the
show index
results in a more direct way.PR Checklist
Please convert it to a draft if some of the following conditions are not met.